Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7958 closed defect (bug) (worksforme)

BuddyBar RTL css after npm update

Reported by: imath's profile imath Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

After updating my node modules, when doing grunt commit the file src/bp-core/css/buddybar-rtl.css is generated. I'm unsure if this file was edited lately.

Should it be committed ?

Change History (3)

#2 @DJPaul
7 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

I'm not seeing any difference on trunk, @imath. I suggest making sure your NPM is up-to-date and node_modules is freshly installed, etc. It's probably a difference in a library.

But generally yes, people forget to run the grunt command, so it's fine to commit it. We should assume the tool should not lie.

#3 @imath
7 years ago

Thanks a lot for your feedbacks, just checked, it's not there anymore :)

Note: See TracTickets for help on using tickets.