Skip to:
Content

BuddyPress.org

Changes between Version 1 and Version 2 of Ticket #7935, comment 6


Ignore:
Timestamp:
09/11/2018 01:53:37 AM (8 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #7935, comment 6

    v1 v2  
    662. Due to the fact that the slugs can be modified by a developer, I'm now using `$parent_slug->css_id` since that uses the component ID for the most part - https://buddypress.trac.wordpress.org/browser/tags/3.1.0/src/bp-core/bp-core-buddybar.php?marks=139-141,147#L113.  XProfile component sets `link_css_id` as the component ID - https://buddypress.trac.wordpress.org/browser/tags/3.1.0/src/bp-xprofile/classes/class-bp-xprofile-component.php?marks=257#L235.
    77
    8 It might make sense to set the `link_css_id` for all components to the component ID just to be safe.  For example, for the Settings component, we would add the `link_css_id` parameter directly after this line - https://buddypress.trac.wordpress.org/browser/tags/3.1.0/src/bp-settings/classes/class-bp-settings-component.php?marks=146#L124 (Update - looks like the Settings component is the only one that doesn't set the `'link_css_id'` parameter, so I've added it to `02.patch`).
     8It might make sense to set the `link_css_id` for all components to the component ID just to be safe.  For example, for the Settings component, we would add the `link_css_id` parameter directly after this line - https://buddypress.trac.wordpress.org/browser/tags/3.1.0/src/bp-settings/classes/class-bp-settings-component.php?marks=146#L124 (**Update** - looks like the Settings component is the only one that doesn't set the `'link_css_id'` parameter, so I've added it to `02.patch`).
    99
    1010Let me know what you think.