Skip to:
Content

BuddyPress.org

Opened 16 months ago

Closed 13 months ago

Last modified 13 months ago

#7917 closed defect (bug) (fixed)

Twenty Seventeen theme unresponsive due to broken layout

Reported by: elhardoum Owned by: djpaul
Milestone: 3.2.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

In many pages, we have unresponsive layout with a horizontal scroll bar, all due to a screen reader text label with the following CSS properties:

`
float: left;
margin: 0;
width: 70%;
`

taking more width than its parent form.

This occurs in the following pages (at least):

  • members index
  • groups index

A simple solution was to add position: relative to the parent form.

Attachments (1)

Screen Shot 2018-07-04 at 23.34.38.png (932.9 KB) - added by elhardoum 16 months ago.

Download all attachments as: .zip

Change History (8)

#1 @elhardoum
16 months ago

In src/bp-templates/bp-legacy/css/twentyseventeen.scss:2863

+ position: relative;

#2 follow-up: @DJPaul
16 months ago

Can you confirm if you're using the Nouveau or Default template pack? You can find the setting in wp-admin > Settings > BuddyPress, one of the tabs.

#3 in reply to: ↑ 2 @elhardoum
16 months ago

Replying to DJPaul:

Can you confirm if you're using the Nouveau or Default template pack? You can find the setting in wp-admin > Settings > BuddyPress, one of the tabs.

Thanks Paul. I am using the default template pack (BuddyPress Legacy). Using BP Nouveau this does not occur, as this template pack does not have stylesheets for themes (e.g twentyseventeen.scss in this case).

#4 @r-a-y
15 months ago

  • Component changed from Core to Templates

Thanks again for your proposed fix, @elhardoum.

@hnla, can you take a look at elhardoum's SCSS change for bp-legacy to see if his approach is valid?

#5 @r-a-y
15 months ago

  • Milestone changed from Awaiting Review to 3.2.0

#6 @djpaul
13 months ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 12226:

Templates, Legacy: fix horizontal scrollbar on member directories on twentyseventeen

Props elhardoum

Fixes #7917

#7 @djpaul
13 months ago

In 12227:

Templates, Legacy: fix horizontal scrollbar on member directories on twentyseventeen

Props elhardoum

Fixes #7917 (3.0 branch)

Note: See TracTickets for help on using tickets.