Warning after deleting xprofile fields group

[djanym]

When removing a custom xprofile fields group - it deletes, but also throwing this warning:
Warning: count(): Parameter must be an array or an object that implements Countable in /var/www/wp/wp-content/plugins/buddypress/bp-xprofile/classes/class-bp-xprofile-group.php on line 214

[boonebgorges]

Just came across this myself. Let's fix in the branch.

[boonebgorges]

So, as far as I can see, this code does nothing. It appears that the fields property of a BP_XProfile_Group object is never populated. In BP_XProfile_Group::get(), the fields property of each group object is populated, but these are stdClass objects, not BP_XProfile_Group. So it's not really possible to write a test that demonstrates the functionality. I'm going to throw an empty() check in front of it, to squelch the error.

[boonebgorges]

In 12210:

Prevent notices on PHP 7.2 when deleting xprofile groups.

Fixes #7916.

[boonebgorges]

In 12211:

Prevent notices on PHP 7.2 when deleting xprofile groups.

Merges [12210] to the 3.0 branch.

Fixes #7916.