Nouveau - Ajax error while leaving the group

[dullowl]

Ajax returns error Error Leaving Group. when trying to leave the group by pressing Leave group button. Here's the screen recording: ​https://i.imgur.com/iG36onc.gif

Buddypress version 3.1.0
WordPress version 4.9.6
Clean installation, no any other plugins or changes in the code.

[elhardoum]

Thanks for reporting. I believe this is a bug.

In ​https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-nouveau/includes/groups/ajax.php#L209 we have

if (  groups_leave_group( $group->id ) ) {
    $response = array(
        'feedback' => sprintf(
            '<div class="bp-feedback error"><span class="bp-icon" aria-hidden="true"></span><p>%s</p></div>',
            esc_html__( 'Error leaving group.', 'buddypress' )
        ),
        'type'     => 'error',
    );
} else {
    /* more code to handle a success group leave
     * e.g show feedback to the user */
}

Which I believe the contributors forgot to check if the group leave function was not successful (negate their conditional check), that is when the error should be returned.

So instead it should be:

if ( ! groups_leave_group( $group->id ) ) {

This fixes the issue for me on a development environment.

[r-a-y]

Thanks for the fix, @elhardoum. We'll address this for v3.2.0.

[r-a-y]

In 12190:

Nouveau: Fix wrong error message showing when leaving a group via AJAX.

Props elhardoum, dullowl.

See #7913 (trunk)

[r-a-y]

In 12191:

Nouveau: Fix wrong error message showing when leaving a group via AJAX.

Props elhardoum, dullowl.

Fixes #7913 (3.x branch)

[r-a-y]

Thanks for the report, @dullowl, and thanks for the fix, @elhardoum !