Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

#7876 closed defect (bug) (fixed)

[BP Nouveau] Cannot translate ‘Post Update’ & "Cancel' string

Reported by: vapvarun Owned by: imath
Milestone: 3.1.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch
Cc:

Description

Post Update and cancel String is mentioned inside js and corrresponding min.js file
/buddypress/bp-templates/bp-nouveau/js/buddypress-activity-post-form.js

Attachments (1)

7876.patch (1.6 KB) - added by imath 2 years ago.

Download all attachments as: .zip

Change History (4)

@imath
2 years ago

#1 @imath
2 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.1.0
  • Version set to 3.0.0

Hi @vapvarun

Thanks a lot for your feedback. I confirm the issue. 7876.patch is fixing it.

#2 @imath
2 years ago

In 12144:

Nouveau Activity Post form: fix missing strings in JavaScript l10n.

Strings for two action buttons (Post Update and Cancel) were wrongly hardcoded into the JavaScript file. This commit adds these two strings to the l10n strings object of the Nouveau Activity Post Form UI.

Props vapvarun

See #7876 (Trunk)

#3 @imath
2 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12145:

Nouveau Activity Post form: fix missing strings in JavaScript l10n.

Strings for two action buttons (Post Update and Cancel) were wrongly hardcoded into the JavaScript file. This commit adds these two strings to the l10n strings object of the Nouveau Activity Post Form UI.

Props vapvarun

Fixes #7876 (Branch 3.0)

Note: See TracTickets for help on using tickets.