Skip to:
Content

BuddyPress.org

Opened 16 months ago

Last modified 10 months ago

#7875 new defect (bug)

BP Nouveau - Group Invites UI, the optional inviter message is never sent to invited users

Reported by: imath Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: needs-patch
Cc:

Description

As This feature was introduced before BuddyPress 2.5 in BP Nouveau, the 'groups_notification_group_invites_message' filter is deprecated. I suggest the attached patch to actually append the user message to the group-invites BP email.

Attachments (1)

7875.patch (2.7 KB) - added by imath 16 months ago.

Download all attachments as: .zip

Change History (3)

@imath
16 months ago

#1 @DJPaul
15 months ago

  • Keywords needs-patch added; has-patch 2nd-opinion removed
  • Milestone changed from Awaiting Review to 4.0

The idea is fine, the patch needs some work because changing the function signature like this can be dangerous. I don't think you can type-hint the first parameter, and you need to handle that possibly being passed a string for backwards compatibility (in case someone is calling the function manually, or has hooked it somewhere else, etc).

(On commit, change the modified since version to 4.0.)

#2 @boonebgorges
10 months ago

  • Milestone changed from 4.0 to Awaiting Contributions
Note: See TracTickets for help on using tickets.