Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 9 days ago

#7875 closed defect (bug) (fixed)

BP Nouveau - Group Invites UI, the optional inviter message is never sent to invited users

Reported by: imath Owned by: imath
Milestone: 6.3.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: needs-patch
Cc:

Description

As This feature was introduced before BuddyPress 2.5 in BP Nouveau, the 'groups_notification_group_invites_message' filter is deprecated. I suggest the attached patch to actually append the user message to the group-invites BP email.

Attachments (2)

7875.patch (2.7 KB) - added by imath 2 years ago.
7875.2.patch (1.8 KB) - added by imath 2 weeks ago.

Download all attachments as: .zip

Change History (9)

@imath
2 years ago

#1 @DJPaul
2 years ago

  • Keywords needs-patch added; has-patch 2nd-opinion removed
  • Milestone changed from Awaiting Review to 4.0

The idea is fine, the patch needs some work because changing the function signature like this can be dangerous. I don't think you can type-hint the first parameter, and you need to handle that possibly being passed a string for backwards compatibility (in case someone is calling the function manually, or has hooked it somewhere else, etc).

(On commit, change the modified since version to 4.0.)

#2 @boonebgorges
22 months ago

  • Milestone changed from 4.0 to Awaiting Contributions

#3 @imath
2 weeks ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Contributions to 7.0.0

This bug has been fixed during 6.0.0 release cycle with the introduction of the BP Invitations feature. We now just need to deprecate the code that is no more used.

@imath
2 weeks ago

#4 @imath
2 weeks ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12714:

BP Nouveau: remove unnecessary code & deprecate a function

The introduction of the BP Invitations feature in BuddyPress 6.0.0 is now making sure the optional Group's inviter message is included into the BP Email sent to the user.

Let's simply remove unnecessary code & deprecate bp_nouveau_groups_invites_custom_message().

Props DJPaul

Fixes #7875

#5 @imath
10 days ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 7.0.0 to 6.3.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

This should actually have been fixed into the 6.0 branch. Reopening this ticket to do so.

#6 @imath
9 days ago

In 12715:

BP Nouveau: move r12714 fix into 6.0 branch

See #7875 (trunk)

#7 @imath
9 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 12716:

BP Nouveau: remove unnecessary code & deprecate a function

The introduction of the BP Invitations feature in BuddyPress 6.0.0 is now making sure the optional Group's inviter message is included into the BP Email sent to the user.

Let's simply remove unnecessary code & deprecate bp_nouveau_groups_invites_custom_message().

Props DJPaul

Fixes #7875 (6.0 branch)

Note: See TracTickets for help on using tickets.