Skip to:
Content

BuddyPress.org

#7863 closed defect (bug) (fixed)

Email Notification for new Private message Formatting

Reported by: dipesh.kakadiya Owned by: DJPaul
Milestone: 3.1.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Messages Keywords: has-patch commit
Cc:

Description

In Email Notification for New message, "usermessage" token strip all tags but that content doesn't show space for line break, On mail content display continues that's looking wired

Actual content:
https://photos.app.goo.gl/Ks9ClA4Nyb602MKp2

Email Preview:
https://photos.app.goo.gl/xRCNn1eJYdWhBVr22

Expected Result:
There should be space between two link.

Attachments (2)

7863.patch (681 bytes) - added by dipesh.kakadiya 19 months ago.
patch file for added filter for message content for email notification
7863.2.patch (694 bytes) - added by imath 19 months ago.

Download all attachments as: .zip

Change History (9)

@dipesh.kakadiya
19 months ago

patch file for added filter for message content for email notification

#1 @dipesh.kakadiya
19 months ago

  • Keywords has-patch added; needs-patch removed

#2 @imath
19 months ago

  • Component changed from Emails to Messages
  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 3.1.0

Good catch @dipesh.kakadiya ! Thanks for the patch.

@imath
19 months ago

#3 @imath
19 months ago

  • Keywords reporter-feedback added; needs-testing removed

Hi @dipesh.kakadiya

I don't think we need to apply all bp_get_the_thread_message_content filters as anyway all tags will be stripped making bp_messages_filter_kses(), for instance, useless.

Instead I suggest to only make sure line breaks are preserved. See 7863.2.patch. Can you confirm this new patch fixes the issue for you ?

#4 @dipesh.kakadiya
19 months ago

@imath

Yeah 7863.2.patch Working fine.

#5 @imath
19 months ago

  • Keywords commit added; reporter-feedback removed

Thanks for your feedback, I will take care of this asap.

#6 @imath
19 months ago

In 12139:

Messages: preserve user message line breaks in e-mail notifications.

props dipesh.kakadiya

See #7863 (Trunk)

#7 @imath
19 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 12140:

Messages: preserve user message line breaks in e-mail notifications.

props dipesh.kakadiya

Fixes #7863 (Branch 3.0)

Note: See TracTickets for help on using tickets.