Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#7853 closed defect (bug) (fixed)

Register page in Trunk is showing %s with username, password etc

Reported by: sbrajesh Owned by: djpaul
Milestone: 3.1.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords:
Cc: sbrajesh

Description

I am running current trunk. The register form is showing %s literal with the username/password etc on the register page.

The problem lies with the mismatching of the number of type placeholders in the format string and the number of args to the sprintf.

There are two possible solutions

  1. Remove the format directives from the labels in "bp_nouveau_get_signup_fields()"
  1. Or revert back to what we had in 3.0 (I believe the change was intentional and should not be reverted, instead option 1 should be used) in "bp_nouveau_signup_form".

The change that triggered it is in

	// Text fields are using strings, radios are using their inputs
		$label_output = '<label for="%1$s">%2$s</label>';	

changed to

		if ( $required ) {
			/* translators: Do not translate placeholders. 2 = form field name, 3 = "(required)". */
			$label_output = __( '<label for="%1$s">%2$s %3$s</label>', 'buddypress' );
		}

For required fields.

Attachments (1)

Selection_582.png (24.6 KB) - added by sbrajesh 2 years ago.

Download all attachments as: .zip

Change History (4)

#1 @djpaul
2 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 12108:

Templates, Nouveau: remove format directives from labels in bp_nouveau_get_signup_fields().

Fixes #7853

Props sbrajesh

#2 @djpaul
2 years ago

In 12109:

Templates, Nouveau: remove format directives from labels in bp_nouveau_get_signup_fields().

Fixes #7853 (branch)

Props sbrajesh

#3 @r-a-y
2 years ago

  • Milestone changed from Awaiting Review to 3.1.0
Note: See TracTickets for help on using tickets.