Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#7850 closed defect (bug) (fixed)

bp_before_member_messages_loop hook not working in BP Nouveau

Reported by: pareshradadiya's profile pareshradadiya Owned by: imath's profile imath
Milestone: 3.1.0 Priority: normal
Severity: normal Version:
Component: Messages Keywords: has-patch commit
Cc:

Description

I'm using bp_before_member_messages_loop to show content above messages list on Inbox page.

The bp_before_member_messages_loop callback function does not fired when BP Nouveau template pack is actve.

I looked into BuddyPress codebase but I couldn't find alternative hook that I could use to output content above messages on Inbox page.

Attachments (3)

7850.patch (5.4 KB) - added by imath 6 years ago.
7850.2.patch (5.5 KB) - added by imath 6 years ago.
Change JS variable name in favor of beforeLoop & afterLoop
7850.3.patch (5.5 KB) - added by imath 6 years ago.
Refresh now that #7847 is fixed

Download all attachments as: .zip

Change History (11)

#1 @imath
6 years ago

I confirm. Thanks for your feedback. I’ll look at it but do not hesitate to suggest a patch :)

#2 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to 3.0.1

#3 @imath
6 years ago

  • Owner set to imath
  • Status changed from new to assigned

@imath
6 years ago

#4 @imath
6 years ago

  • Keywords has-patch added

To test 7850.patch you will need to apply 7847.patch I'm using one of the functions i added in 7847.patch.

7850.patch is creating a specific view for hooks content and add it to the UI if plugins added a PHP action on bp_before/after_member_messages_loop.

It doesn't change anything to what plugin developers did before.

#5 @DJPaul
6 years ago

  • Milestone changed from 3.0.1 to 3.1.0

Milestone renamed

@imath
6 years ago

Change JS variable name in favor of beforeLoop & afterLoop

@imath
6 years ago

Refresh now that #7847 is fixed

#6 @imath
6 years ago

  • Keywords commit added

#7 @imath
6 years ago

In 12133:

Messages UI: Create a new Backbone view to wrap hooks caught output

This new view can be used when hooks caught output cannot be inserted into regular views. bp_before_member_messages_loop and bp_before_member_messages_loop are two good examples.

See #7850 (Trunk)

#8 @imath
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12134:

Messages UI: Create a new Backbone view to wrap hooks caught output

This new view can be used when hooks caught output cannot be inserted into regular views. bp_before_member_messages_loop and bp_before_member_messages_loop are two good examples.

Fixes #7850 (Branch 3.0)

Note: See TracTickets for help on using tickets.