do_action friends_friendship_rejected - argument is useless

[DJPaul]

bp-friends.php - friends_reject_friendship()

The argument passed in the do_action( 'friends_friendship_rejected', ...) is useless. The table entry for $friendship_id is deleted in the BP_Friends_Friendship::reject call, so you can't do anything with it.

Suggest moving the do_action out of the IF, or passing the ID of the user who *sent* the friendship request.

[(none)]

Milestone Friends 1.1 deleted

[apeatling]

Not totally true, since plugins may use that friendship ID stored in some other table or in usermeta. When the friendship is removed this no longer references anything as you say, but it may still be used to delete other entries based on friendship_id by plugins.

[DJPaul]

Ok yes, but it doesn't let me perform an action based on who the user *was*.

[apeatling]

(In [1793]) Fixes #784 props djpaul