Alternative to 'bp_activity_entry_comments' action in bp nouveau

[sbrajesh]

The legacy uses "bp_activity_entry_comments" action to allow adding extra fields into the comment form, In BP Nouveau there are no alternative action.

The action 'bp_activity_entry_comments' is present but it add the extra data outside the form.

We need extra actions to allow injecting in the activity comment form.

[DJPaul]

Let’s use the old action name in the same place in Nouveau — and add a new action to replace where that action currently is in Nouveau.

[imath]

Hi @sbrajesh it looks like this hook was just before the nonce field, do you think we could adapt and use bp_nouveau_submit_button in this part ? Do not hesitate to suggest a patch 😊

[sbrajesh]

Thank you.

It seems to me that using the button in action name might not be good as the action appears in the outside container.

I am unable to think a good name, but something in the form of
`

<?php do_action( 'bp_nouveau_after_new_activity_comment_content' )?>

`
seems more meaningful and appropriate but seems too long.

[DJPaul]

Milestone renamed

[imath]

7839.patch should fix the issue without adding hooks inside the template part.

@sbrajesh can you confirm (ps: the hook name is the same than before: bp_activity_entry_comments) ?

[sbrajesh]

Hi @imath
I can confirm that this works as expected.

Thank you.

[imath]

Thanks a lot for your feedback @sbrajesh I'll commit this in a few hours.

[sbrajesh]

Thank you.

[imath]

In 12148:

BP Nouveau Activity comment form: allow inputs to be added to the form

In BP Legacy, the hook bp_activity_entry_comments is fired inside the activity comment form, letting plugin developers inject custom inputs into this form. The same hook is also available in BP Nouveau but was misplaced out of the comment form.

To adapt to one of this Nouveau principle: try to avoid adding hooks directly into templates using existing template tags or specific wrappers and preserve the same level of customization plugin developers need, we will use the bp_nouveau_submit_button() template tag to wrap and fire this hook into its output.

Props sbrajesh

See #7839 (Trunk)

[imath]

In 12149:

BP Nouveau Activity comment form: allow inputs to be added to the form

In BP Legacy, the hook bp_activity_entry_comments is fired inside the activity comment form, letting plugin developers inject custom inputs into this form. The same hook is also available in BP Nouveau but was misplaced out of the comment form.

To adapt to one of this Nouveau principle: try to avoid adding hooks directly into templates using existing template tags or specific wrappers and preserve the same level of customization plugin developers need, we will use the bp_nouveau_submit_button() template tag to wrap and fire this hook into its output.

Props sbrajesh

Fixes #7839 (Branch 3.0)