Changes between Initial Version and Version 1 of Ticket #7833, comment 3
- Timestamp:
- 05/16/2018 04:26:46 PM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #7833, comment 3
initial v1 6 6 All friendship actions are managed in one ajax handler {{{bp_nouveau_ajax_addremove_friend()}}}, but 2 actions are not sending an ID from the {{{$wpdb->users}}} table but an ID from the {{{$bp->table_prefix . 'bp_friends'}}} table. 7 7 8 For these two actions ({{{'friends_accept_friendship'}}} & {{{' 'friends_reject_friendship''}}}), it makes no sense to check if an ID from the {{{$bp->table_prefix . 'bp_friends'}}} table exists as a user into the {{{$wpdb->users}}} table.8 For these two actions ({{{'friends_accept_friendship'}}} & {{{'friends_reject_friendship'}}}), it makes no sense to check if an ID from the {{{$bp->table_prefix . 'bp_friends'}}} table exists as a user into the {{{$wpdb->users}}} table. 9 9 10 So both 7833.patch or 7833.2.patch are fixing the issue s, the first one edits less code than the other which is less confusing..10 So both 7833.patch or 7833.2.patch are fixing the issue, the first one edits less code than the other which is less confusing.. 11 11 12 12 It's up to what you prefer :)