Changes between Initial Version and Version 1 of Ticket #7826, comment 13
- Timestamp:
- 11/02/2018 01:13:05 PM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #7826, comment 13
initial v1 1 1 I've tested this and it works well! 2 2 3 Looking at the patch, only thing I have to comment on is bp-settings/actions/data.php. I don't think that request handler should be hooked with an anonymous function -- all the other similar registrations in BuddyPress use real namefunctions, and we might as well keep it consistent at this point.3 Looking at the patch, only thing I have to comment on is bp-settings/actions/data.php. I don't think that request handler should be hooked with an anonymous function -- all the other similar registrations in BuddyPress use named functions, and we might as well keep it consistent at this point. 4 4 5 5 I think this is ready @boonebgorges.