Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #7826, comment 13


Ignore:
Timestamp:
11/02/2018 01:13:05 PM (3 years ago)
Author:
DJPaul
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7826, comment 13

    initial v1  
    11I've tested this and it works well!
    22
    3 Looking at the patch, only thing I have to comment on is bp-settings/actions/data.php. I don't think that request handler should be hooked with an anonymous function -- all the other similar registrations in BuddyPress use real name functions, and we might as well keep it consistent at this point.
     3Looking at the patch, only thing I have to comment on is bp-settings/actions/data.php. I don't think that request handler should be hooked with an anonymous function -- all the other similar registrations in BuddyPress use named functions, and we might as well keep it consistent at this point.
    44
    55I think this is ready @boonebgorges.