Unable to dismiss pending email change

[DJPaul]

If you change your email address, you have a confirmation nag show in Settings > General until you click the link in the email or click "dismiss" on the notification.

Both parts are broken with the late_includes() changes in class-bp-settings-component.php.

This check - ​https://github.com/buddypress/BuddyPress/blob/93b68a64452b896eab8a3afb42d70cbc81a08ad8/src/bp-settings/classes/class-bp-settings-component.php#L72 - is returning empty string when you are on /members/admin/settings/.

cc @r-a-y Do we need to check all uses of bp_is_current_action() in the class loading changes you worked on?

[r-a-y]

Good catch, @DJPaul.

My mistake was thinking that the main nav item's default nav slug is what bp_current_action() is.

Do we need to check all uses of bp_is_current_action() in the class loading changes you worked on?

Sure, that would be great.

[DJPaul]

I have checked and can't obviously see any other instances of this.

[djpaul]

In 12088:

Settings: fix loading action code for email address change.

Fixes #7824

Props r-a-y