Skip to:
Content

BuddyPress.org

#7824 closed defect (bug) (fixed)

Unable to dismiss pending email change

Reported by: DJPaul Owned by: djpaul
Milestone: 3.0 Priority: normal
Severity: blocker Version:
Component: Settings Keywords: has-patch
Cc:

Description

If you change your email address, you have a confirmation nag show in Settings > General until you click the link in the email or click "dismiss" on the notification.

Both parts are broken with the late_includes() changes in class-bp-settings-component.php.

This check - https://github.com/buddypress/BuddyPress/blob/93b68a64452b896eab8a3afb42d70cbc81a08ad8/src/bp-settings/classes/class-bp-settings-component.php#L72 - is returning empty string when you are on /members/admin/settings/.

cc @r-a-y Do we need to check all uses of bp_is_current_action() in the class loading changes you worked on?

Attachments (1)

7824.01.patch (549 bytes) - added by r-a-y 17 months ago.

Download all attachments as: .zip

Change History (4)

@r-a-y
17 months ago

#1 @r-a-y
17 months ago

  • Keywords has-patch added

Good catch, @DJPaul.

My mistake was thinking that the main nav item's default nav slug is what bp_current_action() is.

Do we need to check all uses of bp_is_current_action() in the class loading changes you worked on?

Sure, that would be great.

#2 @DJPaul
17 months ago

I have checked and can't obviously see any other instances of this.

#3 @djpaul
17 months ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 12088:

Settings: fix loading action code for email address change.

Fixes #7824

Props r-a-y

Note: See TracTickets for help on using tickets.