Skip to:
Content

BuddyPress.org

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#7801 closed defect (bug) (fixed)

Nouveau: Single-item "tabbed" primary nav doesn't work

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 3.0 Priority: high
Severity: normal Version:
Component: Templates Keywords: has-patch dev-feedback
Cc:

Description

There's a "tabbed primary nav" option for both users and groups in the customizer, but it doesn't work. The CSS selectors are written in such a way that they only apply to subnavs; the settings are checked in a way that always fails (see #7800 [12045]); and CSS classes are improperly generated when creating the nav markup.

I'll attach a patch that does the minimum work required to make primary nav tab styling work, but I'd like review from either @imath or @hnla on it - I'm unsure whether this is a feature that never got implemented, or an old feature that wasn't quite fully taken out :)

Attachments (1)

7801.diff (9.4 KB) - added by boonebgorges 14 months ago.

Download all attachments as: .zip

Change History (4)

@boonebgorges
14 months ago

#1 @imath
14 months ago

I've just tested the patch, it works great.

I'm unsure too. But it's a great improvement, as it does what it's supposed to do. Thank you. I think it was the target though if i understand the issue there : https://github.com/buddypress/next-template-packs/issues/96

Green lights for me about committing it ;)

#2 @boonebgorges
14 months ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 12050:

Nouveau: Fix the 'tabbed style' feature for primary item nav.

Fixes #7801.

#3 @hnla
14 months ago

@boonebgorges Thanks for fix, think I got diverted halfway through or wasn't sure if everything set as tabs was a good idea.

Note: See TracTickets for help on using tickets.