#7801 closed defect (bug) (fixed)
Nouveau: Single-item "tabbed" primary nav doesn't work
Reported by: | boonebgorges | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 3.0 | Priority: | high |
Severity: | normal | Version: | |
Component: | Templates | Keywords: | has-patch dev-feedback |
Cc: |
Description
There's a "tabbed primary nav" option for both users and groups in the customizer, but it doesn't work. The CSS selectors are written in such a way that they only apply to subnavs; the settings are checked in a way that always fails (see #7800 [12045]); and CSS classes are improperly generated when creating the nav markup.
I'll attach a patch that does the minimum work required to make primary nav tab styling work, but I'd like review from either @imath or @hnla on it - I'm unsure whether this is a feature that never got implemented, or an old feature that wasn't quite fully taken out :)
I've just tested the patch, it works great.
I'm unsure too. But it's a great improvement, as it does what it's supposed to do. Thank you. I think it was the target though if i understand the issue there : https://github.com/buddypress/next-template-packs/issues/96
Green lights for me about committing it ;)