Opened 8 years ago
Closed 8 years ago
#7799 closed defect (bug) (fixed)
Nouveau: Vertical nav toggle doesn't work in Customizer
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.0 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Templates | Keywords: | |
| Cc: |
Description
Vertical item nav styling (group, user) is currently controlled by *two* selectors: .bp-vertical-navs on the buddypress-wrap element, and .vertical on the nav element. This causes problems in the Customizer, because toggling 'Display the Group nav vertically...' triggers a refresh where only the .bp-vertical-navs class is present, not .vertical. As such, we have the following situation:
- Your saved setting is for horizontal menus
- You go into the Customizer and navigate to a group page
- You toggle the Group Navigation to 'vertical'
- The page refreshes, but the nav is still vertical in the refreshed frame.
This appears to be due to a bug in bp_nouveau_get_single_item_nav_classes(), where a strict check 1 === is being performed on a "temporary setting" that is never an integer.
In 12044: