Skip to:
Content

BuddyPress.org

#7788 closed defect (bug) (fixed)

BP Nouveau: Activity directory scope tabs count is confusing when it equals to 0

Reported by: imath Owned by: imath
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch commit
Cc:

Description

The more i see it, the more i think we should remove the count spans when they are set to 0 from into Activity scope tabs.

In BP Nouveau, these counts are there to inform about newest activities for each scope. But when i see this, i understand no activities at all were posted in groups or mentions :

https://cldup.com/UgoTVQ8jK6.png

So i suggest the attached patch who makes sure span counts will only be shown when there are newest activities about their corresponding scopes.

https://cldup.com/MIKegiHheT.png

For example, as the stream first started with no counts. When i see the above screencap, i understand better there are 1 new activity and 3 new mentions.

What do you think ?

Attachments (1)

7788.patch (867 bytes) - added by imath 14 months ago.

Download all attachments as: .zip

Change History (4)

@imath
14 months ago

#1 @DJPaul
14 months ago

Yes :)

#2 @imath
14 months ago

  • Keywords commit added; 2nd-opinion removed
  • Owner set to imath
  • Status changed from new to assigned

Let's do this :)

#3 @imath
14 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12034:

BP Nouveau: Activity directory, remove misleading 0 count from tabs.

Into the Activity directory the count spans added to the scope tabs are there to inform about newest activities (HeartBeat) for each scope. Starting the UI with a count set to 0 can be misleading because we could believe this count is about the total number of activities for each scope.

Fixes #7788

Note: See TracTickets for help on using tickets.