Skip to:
Content

BuddyPress.org

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#7781 closed defect (bug) (fixed)

BP Nouveau: Group Create - empty Invites screen when the friends component is not active

Reported by: imath Owned by: imath
Milestone: 3.0 Priority: normal
Severity: major Version:
Component: Templates Keywords: has-patch dev-feedback
Cc:

Description

The fix is pretty easy, but i guess the new bp-nouveau/buddypress/groups/create-invites.php template that brings back the old "need the friends component to be active" interface instead of using the Backbone based one is made on purpose.

https://cldup.com/9YP28m4n0I.png

What do we want to do here ?

Because today it's pretty dirty if the friends component is not active. There's an underscore.js error and no message informing about why this step is empty.

Is there any trouble with allowing all site members invites here ?

If no
then let's apply the attached patch and remove this bp-nouveau/buddypress/groups/create-invites.php template to bring a consistent user experience as i saw the Backbone interface was available once the group was created from the invites screen. I must confess i'm a bit lost. I really don't understand why use a restrictive UI during the creation process, when once the group is created, i can use a non restrictive one ?

If yes
we should probably completely disable the invites create step and group invite screen when the friends component is not active. And remove the Backbone interface to only use he old "need the friends component to be active" interface everywhere.

Because having 2 different interfaces for the same feature is imho not great for users, it's pretty confusing.

Attachments (2)

7781.patch (1.3 KB) - added by imath 14 months ago.
7781.2.patch (6.2 KB) - added by imath 14 months ago.

Download all attachments as: .zip

Change History (14)

@imath
14 months ago

#1 @hnla
14 months ago

I changed the screen template call on purpose, to rectify issues iirc 1. nested forms 2. the function to invite friends from this context did not work due to it being Backbone/JS.

If friends component isn't activated or deactivated surely far earlier BP should bail out of doing anything friends related i.e adding the create screen step period!

Personally I'm not in favour of the invite step here whatsoever but had to divert time to trying to get something workable, certainly as it was the implementation under the normal group invites that the create steps screen was attempting to use was just causing a poor UX.

I'm happy for a solution that you think works though, if you can get the backbone interface working in a similar fashion to main groups invites go for it.

#2 @imath
14 months ago

Thanks for your feedback hnla

the function to invite friends from this context did not work due to it being Backbone/JS.

You mean when the friends component is active and you try to invite friends from the corresponding group create step, it's not working ? Interesting.

Ok i'll check this and find out what needs to be fixed in the Backbone view.

Just to be sure, when you say :

similar fashion to main groups invites go for it.

Does this mean: the way it is in BP Nouveau or the way it is in BP Legacy (restricted to friends) ?

#3 @hnla
14 months ago

Way it is in Nouveau I guess, although I admit feeling slightly confused in the various ways invites works, never been too sure whether I like invite all and not restricted to friends, but not looking to impose an opinion here just looking for solutions that work well :) One thing though the way the steps worked in terms of template parts was resulting in a nested form, that mustn't happen.

#4 @imath
14 months ago

  • Keywords needs-refresh added; dev-feedback removed
  • Owner set to imath
  • Status changed from new to assigned

Ok, got it. I'll improve the nested thing and fix the issue asap before sharing a patch on this ticket.

#5 @hnla
14 months ago

I'll run the patch when you upload, see if there's any styling needing attending to etc.

@imath
14 months ago

#6 @imath
14 months ago

  • Keywords dev-feedback added; needs-refresh removed

@hnla

7781.2.patch is bringing back the Backbone views into the Group invites create step. A missing class was avoiding the UI nav to be populated. It now works when friends component is active or not.

https://cldup.com/YtKRmCucIw.png

I've also made sure there were not nested forms for the group invites create step.

I'll open another ticket tomorrow about the fact the nav is upper the centered title that has been added and about the fact the count bubbles could be more visible imho (eg "Envoyer des invitations [2]")

#7 @boonebgorges
14 months ago

I agree with @hnla 's general sentiment that the Invitations step of group creation is weird, but I think it's late to consider it. @imath 's proposed fix seems good to me.

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


14 months ago

#9 @imath
14 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12039:

BP Nouveau: always include an invite screen to the Group create steps

As the Group Invites UI allows to invite friends or regular members, the Group create steps will include an invites screen even if the Friends component is not active.

Props hnla

Fixes #7781

#10 @hnla
14 months ago

@imath call me stoopid but I fail to see how this functionality works, I create a group reach the invites step select from members the count on the right increases per member selected I click finish, but after that I see nothing how are these invites sent, my users don't appear to get an email, nor do they have a notification in their user account?? What am I missing??

#11 @imath
14 months ago

@hnla it works the same way than when the friends component is active or than in the invites screen once the group is created.

When you add people you have a tab that is added at the bottom « Send invites (Number of invites) ». Before clicking on finish, you need to click on this tab to reach the form to eventually add a message to your invite. Once invites are sent, you can click on finish.

We added style on other tickets because this tab wasn’t visible enough and the bubble with the number of users to invite wasn’t styled.

#12 @hnla
14 months ago

@imath ok my bad then but frankly don't think it's great ui the send invites link isn't overly obvious as the means to send of the invites and we don't read messages ;) but hey ho it works.

Styling though does need addressing.

Note: See TracTickets for help on using tickets.