Skip to:

Opened 6 years ago

Closed 6 years ago

#7769 closed defect (bug) (fixed)

[BP Nouveau] Prevent underscore errors if the activity post-form has been overriden

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch 2nd-opinion commit


I can imagine situations where people would want to completely override the BP Nouveau Activity Post form from their theme adding a buddypress/activity/post-form.php template in it.

In this case, underscore is throwing an error as the main element where is injected the Backbone Post Form is not available. I think it would be safer to avoid it checking for the main element before loading the Backbone views.

See attached patch.

Attachments (1)

7769.patch (616 bytes) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (4)

6 years ago

#1 @DJPaul
6 years ago

  • Keywords commit added

#2 @imath
6 years ago

  • Owner set to imath
  • Status changed from new to assigned

#3 @imath
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11993:

BP Nouveau: only load Activity form views if needed tag is available

Fixes #7769

Note: See TracTickets for help on using tickets.