#7768 closed defect (bug) (fixed)
[BP Nouveau] Unstyled load newest link
Reported by: | imath | Owned by: | imath |
---|---|---|---|
Milestone: | 3.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Templates | Keywords: | has-patch commit |
Cc: |
Description
Hi everyone !
BP Nouveau really looks terrific ! Congrats. When there are newest activities to load, a link is added to the activity stream so that we can load them. This link appears unstyled.
It's a JavaScrip issue in src/bp-templates/bp-nouveau/js/buddypress-activity.js
where the li element is added to the parent of the ul.activity-list. If the attached patch is applyed, then it's really better :)
PS: sorry screencaps are in french ;)
Attachments (1)
Change History (5)
#2
@
7 years ago
- Owner set to imath
- Status changed from new to assigned
Hi @DJPaul thanks for your feedback, I'll commit it in a few hours (after office hours!).
#4
@
7 years ago
@imath just want to comment that we made some changes to avoid loading things like messages in act streams within the act items LI constructs so only concern here is adding the link in a LI element, styling looks fine though, and does need improving from what is current, thanks for patching.
Hi @imath
It does look better! Thanks for testing and writing a patch.
If you want to commit it, please go ahead, otherwise someone else will add it later.