Skip to:
Content

BuddyPress.org

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#7764 closed defect (bug) (fixed)

BP Nouveau: Remove `px` units from image width and height attributes

Reported by: mercime Owned by: mercime
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

BP Nouveau's Activity Widget includes avatar of member cited in the blockquote shown below. Image width and height attritubes already return the rendered width and height of the image in CSS pixels by default in all browsers.

Change:

<img src="//www.gravatar.com/avatar/secret?s=40px&amp;r=g&amp;d=blank" class="avatar user-1-avatar avatar-40px photo" width="40px" height="40px" alt="Profile picture of admin">

To

<img src="//www.gravatar.com/avatar/secret?s=40px&amp;r=g&amp;d=blank" class="avatar user-1-avatar avatar-40px photo" width="40" height="40" alt="Profile picture of admin">

Patch coming up.

Attachments (1)

7764.patch (549 bytes) - added by mercime 14 months ago.

Download all attachments as: .zip

Change History (4)

@mercime
14 months ago

#1 @mercime
14 months ago

  • Keywords has-patch added

#2 @mercime
14 months ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11988:

Nouveau Activity Widget: Remove px units from image width and height attributes.

Fixes #7764.

#3 @hnla
14 months ago

describing the unit :( tbh I would prefer removing the attr altogether for Nouveau.

Note: See TracTickets for help on using tickets.