Skip to:

Opened 6 years ago

Closed 6 years ago

#7751 closed defect (bug) (fixed)

BP-Nouveau - Activity entry template actions are not firing

Reported by: pareshradadiya's profile pareshradadiya Owned by: djpaul's profile djpaul
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch


All activity entry template hooks are not firing because of wrong condition in bp_nouveau_activity_hook function.

Attachments (1)

7751.patch (627 bytes) - added by pareshradadiya 6 years ago.

Download all attachments as: .zip

Change History (4)

6 years ago

#1 @DJPaul
6 years ago

  • Component changed from Activity to Templates
  • Milestone changed from Awaiting Review to 3.0

All the functions that call bp_nouveau_hook( $hook ); are strange and inconsistent. I'm not even sure this complexity is worthwhile, vs. calling do_action. The latter makes it easier for an action to be found during a find-in-files, as well.

I'm inclined to remove this. Thoughts?

#2 @DJPaul
6 years ago

Great spot by the way @pareshradadiya thank you for letting us know :)

#3 @djpaul
6 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11989:

Templates, Nouveau: fix login in filter convenience functions.

Fixes #7751

Props pareshradadiya

Note: See TracTickets for help on using tickets.