Skip to:

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#7749 closed defect (bug) (fixed)

BP Nouveau: Group Activity UL element cannot be a direct descendant of a UL element.

Reported by: mercime's profile mercime Owned by: hnla's profile hnla
Milestone: 3.0 Priority: high
Severity: major Version:
Component: Templates Keywords: has-screenshots


Direct descendants of <ul> and <ol> can only be <li>, <script>, or <template> elements.

W3C HTML5 specs
MDN UL Permitted Content
Specific to rendered markup below from Deque

Rendered markup for a group's activity:

<div class="activity single-group">
	<ul id="activity-stream" class="activity-list item-list bp-list" data-bp-list="activity" style="display: block;">
		<ul class="activity-list item-list bp-list">
			<li class="groups joined_group activity-item mini date-recorded-1523723973" id="activity-538" data-bp-activity-id="538">
			// etc., etc., etc.

Note also that both ULs above have the same class="activity-list item-list bp-list" which causes double padding in the group's activity stream as seen below.

Attachments (1)

activity-group-doublepad.png (33.2 KB) - added by mercime 6 years ago.

Download all attachments as: .zip

Change History (7)

#1 @mercime
6 years ago

  • Keywords needs-screenshots added

#2 @mercime
6 years ago

  • Keywords has-screenshots added; needs-screenshots removed

#3 @hnla
6 years ago

  • Milestone changed from Awaiting Review to 3.0
  • Priority changed from normal to high
  • Severity changed from normal to major

Well spotted, passed me by somehow :(

#4 @hnla
6 years ago

This has to do with recent refactoring to correct issues with how ajax template injection and specifically Heartbeat was rendering, need to re-factor the missed groups act loop single template.

#5 @hnla
6 years ago

  • Owner set to hnla
  • Resolution set to fixed
  • Status changed from new to closed

In 11976:

Nouveau: Update groups single activity template markup

Commit updates the template to remove the hardcoded UL construct & moves the data attr & tokens to the parent div element.

This brings template in line with recent changes on main act loop & members act loop to adjust stream element injection.

Props mercime

Fixes #7749

This ticket was mentioned in Slack in #meta-tracdev by ocean90. View the logs.

6 years ago

Note: See TracTickets for help on using tickets.