#7749 closed defect (bug) (fixed)
BP Nouveau: Group Activity UL element cannot be a direct descendant of a UL element.
Reported by: | mercime | Owned by: | hnla |
---|---|---|---|
Milestone: | 3.0 | Priority: | high |
Severity: | major | Version: | |
Component: | Templates | Keywords: | has-screenshots |
Cc: |
Description
Direct descendants of <ul>
and <ol>
can only be <li>
, <script>
, or <template>
elements.
See:
W3C HTML5 specs
MDN UL Permitted Content
Specific to rendered markup below from Deque
Rendered markup for a group's activity:
<div class="activity single-group"> <ul id="activity-stream" class="activity-list item-list bp-list" data-bp-list="activity" style="display: block;"> <ul class="activity-list item-list bp-list"> <li class="groups joined_group activity-item mini date-recorded-1523723973" id="activity-538" data-bp-activity-id="538"> // etc., etc., etc. </li> </ul> </ul> </div>
Note also that both UL
s above have the same class="activity-list item-list bp-list"
which causes double padding in the group's activity stream as seen below.
Attachments (1)
Change History (7)
#3
@
7 years ago
- Milestone changed from Awaiting Review to 3.0
- Priority changed from normal to high
- Severity changed from normal to major
#4
@
7 years ago
This has to do with recent refactoring to correct issues with how ajax template injection and specifically Heartbeat was rendering, need to re-factor the missed groups act loop single template.
#5
@
7 years ago
- Owner set to hnla
- Resolution set to fixed
- Status changed from new to closed
In 11976:
Well spotted, passed me by somehow :(