BP-Nouveau: Fix Heading Levels

[mercime]

Audit BP-Nouveau and update heading levels as needed. There were at least 5 screens where I've noticed skipped heading levels.

Why area headings important?

• "Headings provide document structure and facilitate keyboard navigation by users of assistive technology. These users may be confused or experience difficulty navigating when heading levels are skipped. --​WAVE browser add-on"
• Per the ​October 2017 Screen Reader Survey, 67.5% use the page headings to finding information on a lengthy web page

[mercime]

Already working on this.

[DJPaul]

👍

[mercime]

In 11913:

Nouveau: Fix skipped heading levels.

See #7728.

[mercime]

Another patch coming soon for other heading changes in some templates.

[hnla]

@mercime cool thanks for catching & updating these are legacy elements and needed addressing.

btw no need to emphasise the importance of headings it's always been the case that they have been in a Standards world :)

[DJPaul]

How many more changes should we expect to resolve this ticket? Can you give an estimate on time if you're able to drive it to completion, @mercime?

[DJPaul]

Closing as presumed fix, given previous work, and no new comments.

[mercime]

@DJPaul Sorry, didn't get email notification for hnla's and your comments. Still working through this for different screens.

@hnla BP Legacy is fine with heading levels since 2.7. Some of us know about the importance of heading levels but many do not :(

[mercime]

7728-groups-create-n-counterpart.patch​ deals with the different heading levels and text used on the Group > Create screens and counterpart Group screens.

7728-groups-remaining-headings.patch​ deals with adding headings on the rest of the Group pages.

7728-members-etal.patch​ deals with heading levels, text, classes for the other components.

[imath]

Hi @mercime

Just tested the 3 patches. Great work!

I would only suggest for 7728-groups-remaining-headings.patch that the Group Activities header might be a H3 because upper there's a H2 for Post Update. You might need to check if the user is a member of the group though because this Post Update might not be there in that case.

I would also suggest that there could be some look alike between single items (Member/Group). For instance, i was a bit surprised to see a header for the Group Activities where there's not one for the User Activities.

I think the Activities Header is interesting for both component when the front page is the activity and not a custom front page, otherwise i'd probably bp-screen-reader-text it :)

[imath]

I've added my suggestions in the above patch ;)

[djpaul]

In 12077:

Templates, Nouveau: improve heading levels on the Group creation/mgnt screens.

See #7728

Props mercime

[djpaul]

In 12078:

Templates, Nouveau: improve heading levels and classes for member templates.

Props mercime, imath

See #7728

[djpaul]

In 12079:

Templates, Nouveau: improve heading on further Groups templates.

Props mercime, imath

Fixes #7728