Skip to:

Opened 6 years ago

Closed 6 years ago

#7728 closed defect (bug) (fixed)

BP-Nouveau: Fix Heading Levels

Reported by: mercime's profile mercime Owned by: mercime's profile mercime
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: Commit dev-feedback has-patch

Description (last modified by mercime)

Audit BP-Nouveau and update heading levels as needed. There were at least 5 screens where I've noticed skipped heading levels.

Why area headings important?

  • "Headings provide document structure and facilitate keyboard navigation by users of assistive technology. These users may be confused or experience difficulty navigating when heading levels are skipped. --WAVE browser add-on"
  • Per the October 2017 Screen Reader Survey, 67.5% use the page headings to finding information on a lengthy web page

Attachments (7)

headings-change-example.png (16.6 KB) - added by mercime 6 years ago.
7728.patch (4.4 KB) - added by mercime 6 years ago.
7728-groups-create-n-counterpart.patch (5.2 KB) - added by mercime 6 years ago.
7728-groups-remaining-headings.patch (3.6 KB) - added by mercime 6 years ago.
7728-members-etal.patch (6.3 KB) - added by mercime 6 years ago.
7728-members-etal.2.patch (7.5 KB) - added by imath 6 years ago.
7728-groups-remaining-headers.2.patch (3.8 KB) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (24)

#1 @mercime
6 years ago

  • Description modified (diff)

#2 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to Awaiting Contributions

#3 @mercime
6 years ago

  • Owner set to mercime
  • Status changed from new to assigned

Already working on this.

6 years ago

#4 @DJPaul
6 years ago

  • Milestone changed from Awaiting Contributions to 3.0

#5 @DJPaul
6 years ago

  • Keywords Commit added


#6 @mercime
6 years ago

In 11913:

Nouveau: Fix skipped heading levels.

See #7728.

#7 @mercime
6 years ago

Another patch coming soon for other heading changes in some templates.

#8 @hnla
6 years ago

@mercime cool thanks for catching & updating these are legacy elements and needed addressing.

btw no need to emphasise the importance of headings it's always been the case that they have been in a Standards world :)

#9 @DJPaul
6 years ago

How many more changes should we expect to resolve this ticket? Can you give an estimate on time if you're able to drive it to completion, @mercime?

#10 @DJPaul
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Closing as presumed fix, given previous work, and no new comments.

#11 @mercime
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@DJPaul Sorry, didn't get email notification for hnla's and your comments. Still working through this for different screens.

@hnla BP Legacy is fine with heading levels since 2.7. Some of us know about the importance of heading levels but many do not :(

#12 @mercime
6 years ago

  • Keywords dev-feedback has-patch added

7728-groups-create-n-counterpart.patch deals with the different heading levels and text used on the Group > Create screens and counterpart Group screens.

7728-groups-remaining-headings.patch deals with adding headings on the rest of the Group pages.

7728-members-etal.patch deals with heading levels, text, classes for the other components.

#13 @imath
6 years ago

Hi @mercime

Just tested the 3 patches. Great work!

I would only suggest for 7728-groups-remaining-headings.patch that the Group Activities header might be a H3 because upper there's a H2 for Post Update. You might need to check if the user is a member of the group though because this Post Update might not be there in that case.

I would also suggest that there could be some look alike between single items (Member/Group). For instance, i was a bit surprised to see a header for the Group Activities where there's not one for the User Activities.

I think the Activities Header is interesting for both component when the front page is the activity and not a custom front page, otherwise i'd probably bp-screen-reader-text it :)

#14 @imath
6 years ago

I've added my suggestions in the above patches ;)

Last edited 6 years ago by imath (previous) (diff)

#15 @djpaul
6 years ago

In 12077:

Templates, Nouveau: improve heading levels on the Group creation/mgnt screens.

See #7728

Props mercime

#16 @djpaul
6 years ago

In 12078:

Templates, Nouveau: improve heading levels and classes for member templates.

Props mercime, imath

See #7728

#17 @djpaul
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 12079:

Templates, Nouveau: improve heading on further Groups templates.

Props mercime, imath

Fixes #7728

Note: See TracTickets for help on using tickets.