Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #7716, comment 9


Ignore:
Timestamp:
03/24/2018 09:57:10 AM (19 months ago)
Author:
hnla
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7716, comment 9

    initial v1  
    88
    99* With positioning I'm trying to avoid using pos:abs  where possible the principle we can follow is moving elements as blocks using either floats and sibling elements overflow hidden to clear floated sibling or flexbox to grid the wrapping element. Therefore blocks .item & .friends-meta.action could be floated left and overflow: hidden respectively with suitable widths for wide screen or flexboxed for avatar .item & meta block as a row.
     10
     11* Something I should have spotted but feel a little bothered by; the class `'fiends-list'` is not very descriptive of this screen for the UL. Think it would be better if we added or changed  to `'friends-requests-list'` and used that as a top level parent class -? Principle of a generic class is sound though i.e 'friends-list' however on the other tab 'friends' we have got `'members-friends-list'` and no `'friends-list' so really these classes need to be better. At this moment I don't think `'friends-list' is used so we could change it to `'friends-request-list'`