Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

#7715 closed defect (bug) (fixed)

BP-Nouveau: Give visual clue for pencil icon for Messages subnav link

Reported by: mercime's profile mercime Owned by: hnla's profile hnla
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

Screen reader users will hear that the link is for composing messages (within <span class="bp-screen-reader-text">), but some users won't know what the pencil icon represents.

Attachments (1)

7715.patch​ (6.1 KB) - added by mercime 7 years ago.

Download all attachments as: .zip

Change History (8)

#1 @hnla
7 years ago

It's one of those icons I would have wanted our bp tooltip implementation on, so think we should look to doing that or better revert to a link text :)

#2 @mercime
7 years ago

I was thinking of reverting the compose link from icon to text at this time. Attaching patch.

@mercime
7 years ago

#3 @DJPaul
7 years ago

  • Milestone changed from Awaiting Review to 3.0
  • Owner set to hnla
  • Status changed from new to assigned

#4 @mercime
7 years ago

  • Keywords has-patch added

#5 @mercime
7 years ago

@hnla when you get the time, please check attached patch which removes the pencil icon and makes the link all text.

#6 @DJPaul
7 years ago

Please may we aim to have this in trunk by next Wednesday 4th April please for beta 1?

#7 @hnla
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11916:

Nouveau: Re-factor Compose pencil icon

Commit changes the compose link to a text one removing the pencil icon.

As an icon it might not have been clear to the purpose of the link, as text it's clearer and is also easier to handle styling/layout within the li element structure.

Props mercime

Fixes #7715

Note: See TracTickets for help on using tickets.