Ajax Responses from friendship functions return wrong button classes

[chherbst]

When clicking on the "Add Friend" and "Cancel Friendship Request" buttons, the buttons get replaced by the ajax response of the functions that are called. But these functions return HTML markup with different classes than the HTML that gets send on the initial page request. This makes it hard for CSS to consistently style those buttons. The attached patch adds the missing classes to the ajax response.

[DJPaul]

We aren't actively updating the BP-Legacy templates.

Given you've provided a patch, it should nonetheless be easy for us to compare the HTML before/after; it is very unlikely break things. Will try to look at for 3.0.0

[DJPaul]

Tested, looks good.

[djpaul]

In 11877:

Legacy, Templates: have friendship AJAX functions return CSS classes consistent with non-AJAX versions.

Fixes #7700

Props chherbst