Skip to:

Opened 2 years ago

Closed 23 months ago

#7700 closed defect (bug) (fixed)

Ajax Responses from friendship functions return wrong button classes

Reported by: chherbst Owned by: DJPaul
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9.3
Component: Templates Keywords:
Cc: chris.p.herbst@…


When clicking on the "Add Friend" and "Cancel Friendship Request" buttons, the buttons get replaced by the ajax response of the functions that are called. But these functions return HTML markup with different classes than the HTML that gets send on the initial page request. This makes it hard for CSS to consistently style those buttons. The attached patch adds the missing classes to the ajax response.

Attachments (1)

0001-add-missing-button-classes-to-ajax-friend-response.patch (3.2 KB) - added by chherbst 2 years ago.

Download all attachments as: .zip

Change History (7)

#1 @DJPaul
23 months ago

  • Milestone changed from Awaiting Review to 3.0

We aren't actively updating the BP-Legacy templates.

Given you've provided a patch, it should nonetheless be easy for us to compare the HTML before/after; it is very unlikely break things. Will try to look at for 3.0.0

#2 @DJPaul
23 months ago

  • Component changed from Core to Templates

#3 @DJPaul
23 months ago

  • Owner set to DJPaul
  • Status changed from new to assigned

#4 @chherbst
23 months ago

  • Cc chris.p.herbst@… added

#5 @DJPaul
23 months ago

Tested, looks good.

#6 @djpaul
23 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11877:

Legacy, Templates: have friendship AJAX functions return CSS classes consistent with non-AJAX versions.

Fixes #7700

Props chherbst

Note: See TracTickets for help on using tickets.