Outlook.com rejects emails from BuddyPress.

[jcrr]

This is a follow-up to #7390.

By request I'm opening this issue. Please, read the retated one (#7390).

Outlook.com users will not receive the BuddyPress emails because of the List-Unsubscribe header.

This issue is resolved by commenting out the lines that add this header as I mentioned in the forums:

// Add 'List-Unsubscribe' header if applicable. 
if ( ! empty( $tokens['unsubscribe'] ) && $tokens['unsubscribe'] !== site_url( 'wp-login.php' ) ) { 
    $user = get_user_by( 'email', $tokens['recipient.email'] ); 
 		 
    $headers['List-Unsubscribe'] = sprintf( 
 		                '<%s>', 
 	                        esc_url_raw( bp_email_get_unsubscribe_link( array( 
 		                'user_id'           => $user->ID, 
 		                'notification_type' => $email->get( 'type' ), 
 		                ) ) ) 
    ); 
}
 

[dcavins]

The original thread: ​https://buddypress.org/support/topic/buddypress-new-user-activation-emails-resends-not-working/

Thanks for opening a ticket, @jccr!

[r-a-y]

Confirmed.

The problem is right now the List-Unsubscribe email header gets added to any BP email even if that email does not support an unsubscribe link. When this occurs, the header that is added is blank -- List-Unsubscribe: <>.

I'm guessing Outlook.com is very particular about the List-Unsubscribe header needing to be complete. If it is not complete, then the email doesn't get received.

01.patch fixes this by ensuring that we do not add the List-Unsubscribe header if we do not have a valid unsubscribe link.

I tested this with an Outlook email address and I'm now able to receive the activation email.

@jcrr - Could you test the patch to verify?

[jcrr]

Tested and working for me too.

Yeah, Microsoft needs a valid unsubscribe link and this patch solve this issue by adding the header only if the unsubscribe link is not empty.

Thanks @r-a-y for changing the priority to high. This patch should be applied as soon as possible so that Outlook.com users can receive the BuddyPress emails.

[r-a-y]

Moving to 2.9.3 milestone.

[r-a-y]

In 11862:

Emails: Only add the 'List-Unsubscribe' header if we have a valid unsubscribe link.

Previously, we were adding a blank 'List-Unsubscribe' header for activation
and change of email address emails. This caused delivery issues for those
using Outlook.com as their email address. It appears that Outlook.com
requires a valid 'List-Unsubscribe' header in order for the email to be
received.

This commit fixes this by only adding the 'List-Unsubscribe' header if we
have a valid email unsubscribe link.

Props jcrr.

See #7697 (2.9-branch)

[r-a-y]

In 11863:

Emails: Only add the 'List-Unsubscribe' header if we have a valid unsubscribe link.

Previously, we were adding a blank 'List-Unsubscribe' header for activation
and change of email address emails. This caused delivery issues for those
using Outlook.com as their email address. It appears that Outlook.com
requires a valid 'List-Unsubscribe' header in order for the email to be
received.

This commit fixes this by only adding the 'List-Unsubscribe' header if we
have a valid email unsubscribe link.

Props jcrr.

See #7697 (trunk)

[r-a-y]

Thanks for reporting the problem and for verifying the fix, @jcrr!

We've added the fix to the upcoming v2.9.3 release, which is maybe a few weeks out from release.

Thanks again!

[DJPaul]

👏🏻

[DJPaul]

Milestone renamed