Skip to:

Opened 6 years ago

Closed 6 years ago

#7688 closed defect (bug) (fixed)

Nouveau activity post form returns unstyled and invalid

Reported by: boonebgorges's profile boonebgorges Owned by: hnla's profile hnla
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords:


When posting to the What's New form using Nouveau, the server sends back fully-rendered markup. This markup is then prepended to the #activity-stream. The problem is that the markup returned from the AJAX request is an li element, while #activity-stream is a div that is the parent of the activity list ul.

I think this broke in [11825].

I'm attaching a patch that I believe solves it, but this could use eyes from @hnla.

Attachments (1)

7688.diff (643 bytes) - added by boonebgorges 6 years ago.

Download all attachments as: .zip

Change History (4)

6 years ago

#1 @hnla
6 years ago

@boonebgorges Hmm so I fixed one thing while missing a further action occurring in the same context, I'll look at what I did and the patch when I get a moment - thanks for spotting & fixing.

#2 @hnla
6 years ago

Tested fix all ways imaginable - Appears to correct issue 100%.
(note to self - open a ticket for one remaining issue with heartbeat, load-newest li element injecting before the primary UL element and introducing a further parent UL)

#3 @hnla
6 years ago

  • Owner set to hnla
  • Resolution set to fixed
  • Status changed from new to closed

In 11853:

Nouveau: Update activity post form Ajax response

In 11825 act loops were refactored to ensure only act entries passed to 'UL' construct, and not single items e.g template messages.

Overlooked was the post form Ajax response injecting direct to the div parent and now rendering 'LI' elements outside the 'UL'.

This commit updates the inject path to ensure content is 'prepended' to the added 'ul.activity-list' not parent '#activity-stream'

Props boonebgorges

Fixes #7688

Note: See TracTickets for help on using tickets.