Skip to:
Content

BuddyPress.org

#7667 closed enhancement (fixed)

xprofile field types - required fields aren't marked with HTML5 "required" property.

Reported by: DJPaul Owned by: djpaul
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Extended Profile Keywords: commit
Cc:

Description

In xprofile field types, required fields aren't marked with the HTML5 "required" property, though they are marked with aria-require.

I don't think we should replace the latter with the former because https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-required_attribute says that "HTML5 now has the required attribute, but aria-required is still useful for user agents that do not yet support HTML5."

There doesn't seem to be harm in using both.

Attachments (1)

7667-01.patch (1.2 KB) - added by DJPaul 17 months ago.

Download all attachments as: .zip

Change History (7)

@DJPaul
17 months ago

#1 @DJPaul
17 months ago

  • Milestone changed from Awaiting Review to Under Consideration

Any objections?

#2 @hnla
17 months ago

Not from me, although really the html attr should replace the aria role one it's true that it's suggested as no harm to have both present so lets do just that!

#3 @mercime
17 months ago

I second the motion.

#4 @hnla
17 months ago

Tested this patch in real time and seems good, it corrects the problem I had with xprofile inputs and styling html atts.

#5 @hnla
17 months ago

  • Keywords commit added
  • Milestone changed from Under Consideration to 3.0

#6 @djpaul
17 months ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11834:

xprofile: add HTML required attribute to mandatory profile fields.

The value is not added for users with bp_moderate as those users can already bypass field requirements..

Fixes #7667

Note: See TracTickets for help on using tickets.