Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#7662 closed defect (bug) (maybelater)

Hidden groups shouldn't 404 if you do not have access

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.6
Component: Groups Keywords: dev-feedback has-patch 2nd-opinion ux-feedback
Cc:

Description

After looking at #7659, I decided to look into why we throw a 404 when we're on a hidden group instead of letting the user see a message of some kind.

Came across #3462 with the following explanation:


For Hidden groups, I think we should change the behaviour so that if you don't have access, (all of) the link(s) 404. At the minute, you can see a "this is a hidden group and only invited members can join" message, but you can view the group title, description, and see the admin/moderator avatars.
This would be the same behaviour as if you try to access the group admin page URL without authorisation (it 404s), and I think it would be more consistent, as well as having the benefit of keeping the hidden group's title and description hidden.

The latter could be achieved by updating the templates but that means putting core logic into the default theme(!).


The current behavior is poor UX in my opinion.

It seems the main points for throwing a 404 is to hide group data such as the title, description and avatars from being shown.

If that is the case, couldn't we just use wp_die() to output a message?

Attached patch does this and also displays a login form if the user isn't logged in.

Screenshot:

https://s9.postimg.org/8qnxpqpfj/2018-01-18_112932.png

Patch is a working example, but we'd probably want to style the login form for a final iteration. wp_die() doesn't have a hook where we can inject CSS so we'd either have to override wp_die() via the 'wp_die_handler' filter or use inline CSS...

Let me know what you think.

Attachments (1)

7662.01.patch (1.3 KB) - added by r-a-y 6 years ago.

Download all attachments as: .zip

Change History (4)

@r-a-y
6 years ago

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


6 years ago

#2 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to Under Consideration

For what it's worth, I still agree with the comments I made in the linked tickets from ~6 years ago.

#3 @DJPaul
6 years ago

  • Milestone Under Consideration deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Given no feedback from anyone else in the last 6 weeks, and that I feel very strongly about this, I don't think we should make this change. If a third party wants to contribute to the discussion, please re-open and comment.

Note: See TracTickets for help on using tickets.