Skip to:
Content

Changes between Initial Version and Version 1 of Ticket #7642, comment 2


Ignore:
Timestamp:
12/08/2017 04:54:44 PM (7 months ago)
Author:
hnla
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7642, comment 2

    initial v1  
    33To my mind I see that create_function() as being redundant, seems we're building a series of functions in advance of needing them. For my purposes it seemed commonsensical to back up to `buddypress()->signup->errors` where I knew I had the required strings, use directly to pass to one function to build out markup around the string.
    44
    5 What I guess I worry about now though is that you mention using the hook to generate custom messages on reg fields, as my approach I think does break this ( guess I could dedicate the new function to the reg fields and add in a apply_filter for access?) If the error string is not in the BP global it can't be used or the bp global string would need changing .
     5What I guess I worry about now though is that you mention using the hook to generate custom messages on reg fields, as my approach I think does break this ( guess I could dedicate the new function to the reg fields and add in a apply_filter for access?) If the error string is not in the BP global it can't be used or the bp global string would need changing.
     6
     7>for the purposes of Nouveau, this add_action() call will do nothing, right?
     8Yes this anonymous function to create those add_actions for errors won't be used - at least not on the reg screen - I ought to check other form fields though, which I haven't done tbh.