Opened 7 years ago
Closed 7 years ago
#7641 closed enhancement (fixed)
Add "IDs only" return format option for BP_Signup::get().
Reported by: | espellcaste | Owned by: | espellcaste |
---|---|---|---|
Milestone: | 3.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Members | Keywords: | has-patch has-unit-tests |
Cc: |
Description
Inspired by #7609. I think BP_Signup::get() could use an update for fetching ids only.
Patch in the works.
Attachments (2)
Change History (8)
#2
@
7 years ago
While we're changing this code:
$signup->id = intval( $signup->signup_id );
Can you please look into why this value is not being returned as an integer? Is it a bug somewhere else (our code, or WP's)?
#4
@
7 years ago
- Component changed from (not sure) to Members
- Keywords has-patch has-unit-tests added; needs-patch needs-unit-tests removed
- Type changed from defect (bug) to enhancement
@DJPaul I'm not sure where to look. I looked at how it is added and don't see a problem there. I'll defer this question to @boonebgorges, he is well versed in BP_Signup than me and probably will answer better.
So far, I presume whoever did that wanna just to ensure it is an integer.
--
About the patch, great! :)
#5
@
7 years ago
Can you please look into why this value is not being returned as an integer?
$signup
is a row pulled from a $wpdb->get_results()
database query. $wpdb->get_results()
results are always arrays/objects with string values. https://buddypress.trac.wordpress.org/browser/tags/2.9.2/src/bp-members/classes/class-bp-signup.php?marks=210,222#L200
Correct one!