Cover image orphaned when user is deleted

[antipole]

When a WordPress user is deleted, WP tidies up and deletes any user avatar, normally stored in /uploads/avatars/<usernumber> and the enclosing folder.

However, when a BuddyPress user is deleted through WordPRess, any cover image, normally stored in /uploads/buddypress/members/<usernumber> is left orphaned.

I think the cover images and the enclosing folder should be deleted.

This is the case for v2.9.2, which is not in the version list pull-down.

Thanks for the good work!

[DJPaul]

We need to update something like bp_core_delete_avatar_on_user_delete() to do this.

[boonebgorges]

I started writing the patch (which is easy) but got caught up on the unit tests (which are almost impossible, because we have no procedural way of setting cover images). Tests are probably a nice-to-have, but not a must, for this ticket.

• Added functions to delete the user’s cover image and related folder during user deletion.
• Ensure cover images are properly removed when a user is deleted by hooking into delete_user and wpmu_delete_user.
• This prevents orphaned cover image files in /uploads/buddypress/members/<user_id>.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/7636

[amitraj2203]

Hi @boonebgorges @DJPaul,

I've raised a [PR]​https://github.com/buddypress/buddypress/pull/409 for this ticket, could you please review it when you get a chance?

Thanks!

Hey @boonebgorges, just pinging you for a review on this PR. I’d really appreciate it if you could take a look. Thanks!