Check for logged-in user on bp_activity_add_user_favorite

[espellcaste]

On wp-cli-buddypress, regardless if you add a user_id, bp_activity_add_user_favorite( $activity_id, $user_id = 0 ) always returns false because it checks for is_user_logged_in().

I'd like to suggest a change in the logic so that when I a user_id is provided, this logged_in checked is not called.

[espellcaste]

Patch inside! There is no need for the logged_in function.

[espellcaste]

Upon further look, bp_activity_add_user_favorite and bp_activity_remove_user_favorite needed the logged_in check removed. Patch ^.

[djpaul]

In 11751:

Activity: fix favouriting functions for CLI use.

Don't require authenticated user in favouriting functions, especially as the function accepts an optional $user_id parameter.

Fixes #7623

Props espellcaste