Skip to:
Content

Opened 7 months ago

Closed 7 months ago

#7617 closed defect (bug) (fixed)

refresh_blog_details is deprecated in WordPress 4.9

Reported by: imath Owned by: boonebgorges
Milestone: 2.9.2 Priority: normal
Severity: normal Version: 2.3.0
Component: Blogs Keywords: has-patch
Cc:

Description

Hi team !

I hope you are all doing great :) I just found a little notice error into the Blogs component due to the use of a deprecated hook in WordPress 4.9.

I think the attached patch is fixing the issue, as the very promising 3.0 release is due in 6 days, I suggest this ticket to be fixed before, if possible.

😗

Attachments (1)

7617.patch (759 bytes) - added by imath 7 months ago.

Download all attachments as: .zip

Change History (9)

@imath
7 months ago

#1 @hnla
7 months ago

Noticed this on Nouveaus github/travis checks for WP trunk tests throwing fails.

#2 follow-up: @DJPaul
7 months ago

3.0 won't be out until after December.

#3 @johnjamesjacoby
7 months ago

Patch looks OK. There might be more places this needs fixing, particularly around the multisite abstraction layer.

#4 @boonebgorges
7 months ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 11720:

In WP 4.9+, don't use deprecated 'refresh_blog_details' hook.

Props imath.
Fixes #7617.

#5 in reply to: ↑ 2 @netweb
7 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to DJPaul:

3.0 won't be out until after December.

WordPress 4.9 is scheduled for November 14th

Should this be included in a minor release, 2.9.2 for example?


Also reopening as the PHPDoc block here also needs updating from:

https://buddypress.trac.wordpress.org/browser/trunk/src/bp-blogs/bp-blogs-functions.php#L551
"Hooked to 'refresh_blog_details', which is notably used when editing a site under "Network Admin > Sites"."

#6 @boonebgorges
7 months ago

  • Milestone changed from 3.0 to 2.9.2

Picky, picky :-D

2.9 branch is fine with me.

#7 @boonebgorges
7 months ago

In 11721:

After [11720], update bp_blogs_delete_url_blogmeta() description.

Props netweb.
See #7617.

#8 @boonebgorges
7 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 11722:

Update blog cache clearing to be compatible with WP 4.9+.

Merges [11720] and [11721] to the 2.9 branch.

Fixes #7617.

Note: See TracTickets for help on using tickets.