Skip to:
Content

BuddyPress.org

Opened 22 months ago

Closed 21 months ago

Last modified 21 months ago

#7594 closed defect (bug) (fixed)

Strip slashes from passwords before checking for backslashes

Reported by: JohnPBloch Owned by: djpaul
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9.0
Component: Settings Keywords: has-patch
Cc:

Description

When saving a password in BuddyPress, it should unslash the password before checking for backslashes. This is what core does when saving user data. WordPress passwords may contain ' single and " double quotes in them, which will arrive from POST data slashed.

Attachments (1)

7594.patch (682 bytes) - added by JohnPBloch 22 months ago.

Download all attachments as: .zip

Change History (4)

@JohnPBloch
22 months ago

#1 @JohnPBloch
22 months ago

  • Keywords has-patch added

Not a whole lot going on in the patch, just fixes the issue. :D

#2 @djpaul
21 months ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11704:

Core: strip slashes from passwords before checking for backslashes.

Fixes #7594

Props JohnPBloch

#3 @DJPaul
21 months ago

  • Milestone changed from Awaiting Review to 3.0

Great find @JohnPBloch, thank you for the patch. That's probably been there 8 years. :)

Last edited 21 months ago by DJPaul (previous) (diff)
Note: See TracTickets for help on using tickets.