Skip to:
Content

Opened 5 months ago

Closed 4 months ago

#7575 closed defect (bug) (fixed)

Admin common style selectors must be more specific

Reported by: geminorum Owned by: slaFFik
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.8.2
Component: Administration Keywords:
Cc:

Description

Apparently BuddyPress adds common styles to all admin pages, and appends a buddypress class to the html body. for example:

.buddypress code {
    background-color: #e0e0e0;
    color: #636363;
    font-size: 1em;
}

it affects all code tags on all admin page, and frankly not a good practice.

Change History (3)

#1 @DJPaul
4 months ago

  • Milestone changed from Awaiting Review to 3.0

We add some common wp-admin styles across, yes, because we set some CSS for menu icons and to modify parts of the users list table (if I remember correctly).

I agree this style is too general. It was probably added innocently to help style the Credits page, so I'm going to #yolo tweak the selector for now as a quick fix.

#2 @DJPaul
4 months ago

My guess was right, see r11425

#3 @djpaul
4 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 11672:

Admin: make some CSS in common admin styles specific to BP screens.

Fixes #7575

Props geminorum

Note: See TracTickets for help on using tickets.