General settings form field markup

[henry.wright]

The "New Password" and "Repeat New Password" text in the settings form appears after the associated input field(s) which could be confusing to some users. I suggest we move the text so it appears before the input(s). I also suggest we use <label> markup around this text.

[hnla]

@henry.wright Please point to the offending file where label elements don't exist.

As far back as ​https://buddypress.trac.wordpress.org/attachment/ticket/6531/6531-settings-general.patch mercime updated to add a label element but other labels did exist before this.

Edit Ok see what you meant but that bare naked abomination passing as text wasn't a label, I was taking literally the remark about no labels when there were two albeit one being visually hidden but that was for a reason to ensure existing layouts didn't change yet provide the correct Stndards markup where possible. Now this has been changed you will affect layouts but hey ho!

[mercime]

per patch

[mercime]

@henry.wright as @hnla mentioned above, I added a label a while back in r10089 but had made it for screen readers only to keep in line with the design at the time.

Glad you brought this up though as it gave an opportunity to improve the accessibility of the form after r10089. Attached 7546.patch​ with screenshot:

• Made the label for "pass2" visible by removing the bp-screen-reader-text class
• Removed the redundant text "Repeat New Password" after the input field for "pass2"
• Associated "New Password" with the input field for "pass1"

[hnla]

'New Password' just looks a bit out of place now - this is the problem in expending energy on these old templates, nothing short of re-writing fully is worth the effort.

[mercime]

updated

[mercime]

as seen in 2014 theme

[mercime]

@hnla updated screenshot and patch which removes "New Password" :)

[hnla]

@mercime yep looks much better don't you think? perhaps we update ( leave blank for no change ) to ( Enter new password, leave blank for no change ) - no more than a passing thought though.

Prefer the wider submit is that a change or was that done in companion styles for a tablet screen view? i.e is this a diff browser view?

[mercime]

yep looks much better don't you think?

@hnla yes :D

perhaps we update ( leave blank for no change ) ... no more than a passing thought though.

Suggest that we keep text to what's already there

Prefer the wider submit is that a change or was that done in companion styles for a tablet screen view? i.e is this a diff browser view

I was checking the patch on the twenty-xxx themes and the Twenty Fourteen theme was at bat when I took the screenshot on Chrome.

[mercime]

In 11607:

Improve markup of Members settings - general screen.

Props mercime, hnla.
Fixes #7546.