Groups member loop missing bp_parse_args

[modemlooper]

​https://buddypress.trac.wordpress.org/browser/trunk/src/bp-groups/bp-groups-template.php#L3887

its still using wp_parse_args

No way to filter loop with.

bp_before_{filter}_parse_args

example:

$r = bp_parse_args( $args, array(
	'group_id'            => bp_get_current_group_id(),
	'page'                => 1,
	'per_page'            => 20,
	'max'                 => false,
	'exclude'             => false,
	'exclude_admins_mods' => $exclude_admins_mods,
	'exclude_banned'      => 1,
	'group_role'          => false,
	'search_terms'        => $search_terms_default,
	'type'                => 'last_joined',
), 'has_group_members' );

[DJPaul]

Sure, it shouldn't take very long to change these out.

[dcavins]

Use bp_parse_args() instead of wp_parse_args().

[dcavins]

I've added a patch that uses bp_parse_args() instead of wp_parse_args() in the groups component. I'm not sure that every instance needs a bp_parse_args, though. For instance, args are parsed in groups_get_groups(), then those args are passed to BP_Groups_Group::get() where they are parsed again. It seems like we should use one or the other, unless someone can come up with a use case where both would be needed. (And if we only use bp_parse_args() in one or the other, I'm assuming we'd add it to the "deep" function, BP_Groups_Group::get(), and add a note above the wp_parse_args() call in groups_get_groups().)

If we can come up with some general guidance for when we want to use bp_parse_args() generally, I'll refine this patch. Thanks!

[espellcaste]

Really good @dcavins.

I would argue to add on the "deep" function, as the high-level is the one actually doing the query. In this way, people using the deep level ones would be filtered correctly.

Adding on both places seems duplicate. Like you said, a use case would be good to evaluate it.

I also think this is a good opportunity to add to the other components to keep it consistent.

[DJPaul]

@dcavins Any interest updating this based on @espellcaste's feedback?

[dcavins]

@DJPaul Sure thing. I'll make some changes and reupload.

[dcavins]

I've updated the patch, and can at least imagine a use-case for every bp_parse_args() I've added. Thanks for your comments in advance.

[dcavins]

Use bp_parse_args() instead of wp_parse_args() to take advantage of context-aware filter points.

[DJPaul]

Looks good

[djpaul]

In 11805:

Groups: use bp_parse_args() in low-level parts of the codebase.

These replace calls to wp_parse_args(). Our version supports a before/after filter, giving flexibility to third-party developers.

Fixes #7529

Props dcavins, espellcaste.