Required xprofile fields are not validated

[rmichel0]

There is an issue with the custom xprofile fields editing (replicated on ​http://demos.buddyboss.com/boss/) when following this steps:

1. Set a xprofile field as required
2. Edit your profile, empty the required field
3. No error message is displayed, and the required field is saved empty

(you can try on the buddyboss demo by setting the bio field as required)

I saw that it was an issue that should have been fixed in 2.0:
​https://buddypress.trac.wordpress.org/ticket/5595
But it still happen with the last version of Buddypress.

[hnla]

Confirmed on a single site trunk install - changing an existing field to required, then editing the profile on frontend to a blank/empty field results in it being saved.

Probably needs further conditions checking.

[henry.wright]

Does the type of field matter or does this apply to all fields?

[rmichel0]

@henry.wright This apply to all fields I tested it for - text input fields, textarea fields. I didn't checked for other field types, but it seems to be a general issue with how the required fields are handled.

[Mamaduka]

This only happens when current user has 'bp_moderate' caps.

This is how we currently check, if field is required in xprofile_screen_edit_profile:

$is_required[ $field_id ] = xprofile_check_is_required_field( $field_id ) && ! bp_current_user_can( 'bp_moderate' );

This logic was introduced in r10232.

[henry.wright]

@Mamaduka in that case I guess this is a feature, rather than a bug?

[Mamaduka]

@henry.wright yeah. Looks like this was intended to be feature, but I find it confusing. E.g. when you add required field, lets say in Gravity Forms, it's required for everyone.

I think we'll see similar reports again, if we don't clarify different UX for users with 'bp_moderate'.

[hnla]

Closing this then as a 'wontfix' as it's only a higher level user that can do this and not general users.

[rmichel0]

I can't replicate the following assumption: "This only happens when current user has 'bp_moderate' caps.".
The bug occurs for regular user (with subscriber role). Not sure if it has been tested thoroughly and if this should be really be set as wontfix.

[hnla]

@rmichel0 I have just run further checks and as a required field I cannot empty the input and save.

Logged in as a subscriber.
Filling in a field previously empty but required ( created subsequent to user joining ).
Returning to edit screen and attempting to empty the field and save results in error message that it's a required field.

Can we ensure this is tested with a plain vanilla setup, WP theme, no additional plugins, as you do state in the OP that this is seen running with BuddyBoss.

[DJPaul]

I think the case found here is probably what I've just dealt with in #7664.