Performance improvement for bp_is_user_spammer in member loops

[sbrajesh]

bp_is_user_spammer() causes O(n) queries in member loop. This can be cut down to zero by adding another case in the switch/case block.

We already have the members info available for the looping member and even though it is not WP_User, It does have the properties needed in the function for checking status.

Please see the attached patch.

If you want to test the behaviour, Please try adding some information in members loop based on bp_is_user_spammer condition. yes, the spam users won't be listed in the members directory but there are cases, where we need this test in members loop.

It will be nice to have this enhancement.

Thank you
Brajesh

[DJPaul]

I like it!

[djpaul]

In 11663:

Members: improve bp_is_user_spammer() performance when used in Member loops.

Fixes #7478

Props sbrajesh