Adding condition check on page delete

[raftaar1191]

When I am running PHPUnit getting a Warning that

`PHP Warning: array_search() expects parameter 2 to be array, string given in wp-content/plugins/buddypress/src/bp-core/bp-core-functions.php on line 774
`

[raftaar1191]

Patch for ticket number 7469

[johnjamesjacoby]

Hi @raftaar1191, thanks for the report.

Every usage of bp_core_get_directory_page_ids() assumes an array is returned. In addition, each usage has inconsistent type-casting on that return value.

We can (very safely) circumvent this (and potentially other similar issues) by ensuring it always returns an array, and removing the inconsistent type-casting.

[johnjamesjacoby]

This may be related to the $status parameter value of all not returning all pages in bp_core_get_directory_page_ids(). It still continues to skip the activate and register static pages. See r9180, r9189, #6043.

[johnjamesjacoby]

In 11513:

Core: Make sure trashed activate and register pages are unset in bp_core_get_directory_page_ids().

This flips the order of 2 conditions, which incorrectly included trashed pages for the activate & register components.

In addition, normalize the return value & type-casting of bp_core_get_directory_page_ids() to ensure it is always an array, even if an empty one.

Fixes #7469.