Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 6 years ago

#7463 closed defect (bug) (fixed)

PHPUnit 6 compatibility

Reported by: netweb's profile netweb Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Cc:

Description

Via ​#WP39822

PHPUnit no longer supports PHPUnit_Framework_TestCase as the base class.
​https://github.com/sebastianbergmann/phpunit/blob/6.0/ChangeLog-6.0.md#600---2017-02-03

$ phpunit 
Installing...
Running as single site... To run multisite, use -c tests/phpunit/multisite.xml
PHP Fatal error:  Class 'PHPUnit_Framework_TestCase' not found in /Users/miyauchi/wp-core/trunk/tests/phpunit/includes/testcase.php on line 15

I wrote aliases for it.
It looks woking fine with phpunit 5.6 and phpunit 6.

Related:
​https://github.com/wp-cli/wp-cli/issues/3802

Attachments (1)

7463.patch​ (2.0 KB) - added by netweb 6 years ago.

Download all attachments as: .zip

Change History (5)

#1 @r-a-y
7 years ago

  • Keywords reporter-feedback added; needs-patch removed

PHPUnit 6 support was added to WP 4.7-branch as of ​https://core.trac.wordpress.org/ticket/39822#comment:25.

Do we want to specify a specific version of PHPUnit to use with Travis for WP 4.7 tests?

#2 @DJPaul
6 years ago

  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 3.0

@netweb can you just get this done in trunk, please?

@netweb
6 years ago

#3 @netweb
6 years ago

  • Keywords has-patch commit added

Tested 7463.patch​ on my fork ​https://travis-ci.org/ntwb/BuddyPress/builds/267086745

#4 @netweb
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [11674]:

Build Tools: Use PHPUnit 6.x for PHP 7.x and WordPress > 4.7 Travis CI jobs

Fixes #7463.

Note: See TracTickets for help on using tickets.