Skip to:
Content

Opened 7 months ago

Closed 3 months ago

#7452 closed defect (bug) (fixed)

Plugin short descriptions are limited to 150 characters

Reported by: garrett-eclipse Owned by: johnjamesjacoby
Milestone: 2.9 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

Hello,

Super minor, while translating found this string in the Readme which is missing the last g for messaging.

String;
BuddyPress helps site builders and WordPress developers add community features to their websites, with user profile fields, activity streams, messagin

Permalink - https://translate.wordpress.org/projects/wp-plugins/buddypress/dev-readme/en-ca/default?filters%5Boriginal_id%5D=3339332

Cheers

Change History (16)

#1 @garrett-eclipse
7 months ago

In trunk I found a string that seems related so assuming this is what the string mentioned in ticket should actually be as it's a truncated version.

String;
BuddyPress helps site builders and WordPress developers add community features to their websites, with user profile fields, activity streams, messaging, and notifications.
Permalink - https://translate.wordpress.org/projects/wp-plugins/buddypress/dev/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=3339331&filters%5Btranslation_id%5D=48021937

Cheers

This ticket was mentioned in Slack in #meta-i18n by netweb. View the logs.


7 months ago

#3 @netweb
7 months ago

  • Keywords close added

Both readme.txt's for trunk and stable contain the correct string: BuddyPress helps site builders and WordPress developers add community features to their websites, with user profile fields, activity streams, messaging, and notifications.

https://buddypress.trac.wordpress.org/browser/trunk/src/readme.txt#L10
https://buddypress.trac.wordpress.org/browser/branches/2.8/src/readme.txt#L10

It looks like the readme parser for translate.w.org has a glitch in the matrix:

Reported here: https://wordpress.slack.com/archives/meta-i18n/p1488249693422576
The following readme.txt string has been truncated from the source:

  • String: https://translate.wordpress.org/projects/wp-plugins/buddypress/dev-readme/en-ca/default?filters%5Boriginal_id%5D=3339332
  • Source: https://plugins.trac.wordpress.org/browser/buddypress/trunk/readme.txt#L10
  • The string should be: BuddyPress helps site builders and WordPress developers add community features to their websites, with user profile fields, activity streams, messaging, and notifications.
  • It is missing the last 21 characters: g, and notifications.

#4 @netweb
7 months ago

  • Keywords needs-patch added; close removed
  • Milestone changed from Awaiting Review to 2.9
  • Summary changed from Readme string missing g for messagin to Plugin short descriptions are limited to 150 characters

Via https://wordpress.slack.com/archives/meta-i18n/p1488251569459568

dd32 [2:12 PM] So there you have it, plugin short descriptions are truncated to 150char, as you can see in the header of See https://wordpress.org/plugins/buddypress/

#5 @garrett-eclipse
7 months ago

Thanks @netweb appreciate you doing the legwork there, sounds like you have it under control there prompting a shorter description. Here if you need me, Cheers

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


7 months ago

#7 @netweb
7 months ago

  • Keywords needs-unit-tests added

Via Slack: https://wordpress.slack.com/archives/buddypress/p1488278198207249

johnbillion [9:36 PM] Ooh that should have a unit test that reads the readme.txt file and counts the length of the description.

Great idea :+1

#8 @r-a-y
4 months ago

  • Keywords dev-feedback added; needs-unit-tests removed

So what do we have to do here? Do we need to truncate our short description for translate.wordpress.org?

Here's an attempt at 150 characters:

BuddyPress helps site builders and developers add community features to their websites. Profiles, groups, activity, friends, messaging, notifications.

#9 @garrett-eclipse
4 months ago

@r-a-y I believe this has become a two parter;

  1. Fix the length to be 150 characters, which you've started.
  2. Introduce "a unit test that reads the readme.txt file and counts the length of the description." (johnbillion via slack)

Slack Reference - https://wordpress.slack.com/archives/buddypress/p1488278198207249
Thanks

#10 @r-a-y
4 months ago

I think the unit test is overkill as the short description is rarely updated, but if someone wants to write a unit test for this, feel free to do so!

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.


4 months ago

#12 @r-a-y
4 months ago

  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

#13 @hnla
3 months ago

We could squeeze this in before string freeze point? - hesitating to punt to 3.0 for the moment.

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


3 months ago

#15 @hnla
3 months ago

  • Milestone changed from 2.9 to 3.0

#16 @johnjamesjacoby
3 months ago

  • Keywords needs-patch dev-feedback removed
  • Milestone changed from 3.0 to 2.9
  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r11615.

Note: See TracTickets for help on using tickets.