Trailing slash needed for URLs for compatibility with LiteSpeed

[allianse]

There is a problem for accept a friend with Bosstheme and LiteSpeed Web Server

Please find the file attached with modified lines:

/**
 * ORIGINAL SCRIPT
 */
 //return apply_filters( 'bp_get_friend_accept_request_link', wp_nonce_url( bp_loggedin_user_domain() . bp_get_friends_slug() . '/requests/accept/' . $friendship_id, 'friends_accept_friendship' ), $friendship_id );

/**
 * UPDATED SCRIPT (23-FEB-2017)
 * To avoid the Accept request URL issue 
 */
return apply_filters( 'bp_get_friend_accept_request_link', wp_nonce_url( bp_loggedin_user_domain() . bp_get_friends_slug() . '/requests/accept/' . $friendship_id.'/', 'friends_accept_friendship' ), $friendship_id );

Please modify the file before release next update

Regards

[allianse]

bp-friends-template.php

[r-a-y]

Hi,

Thanks for the report. It looks like you added a trailing slash to the end of the accept friendship URL.

Since this behavior isn't a regression from a change we made in v2.8.0, this fix will have to wait until v2.9.0.

In the meantime, you can fix this without touching core code by adding the following to your theme's functions.php or ​wp-content/plugins/bp-custom.php:

add_filter( 'bp_get_friend_accept_request_link', 'trailingslashit' );
add_filter( 'bp_get_friend_reject_request_link', 'trailingslashit' );

It might also be possible to address this in your config for LiteSpeed to add a trailingslash to all URLs.

---

Devs: This might be a good chance to audit all other similar links.

[r-a-y]

I've audited all our template link functions to add a trailing slash where necessary.

Question: We use a mis-mash of either trailingslashit() vs. simply adding a / to the end of a link. Which one do we prefer?

In 02.patch, I've opted to use trailingslashit(), but let me know if you have any issue with this.

[johnjamesjacoby]

I think this should patch should use user_trailingslashit(), which does the trailing slash based on the permalink rules.

[johnjamesjacoby]

(Editing the formatting of the original report a bit.)

[r-a-y]

I think this should patch should use user_trailingslashit(), which does the trailing slash based on the permalink rules.

user_trailingslashit() would make sense if we supported rewrite rules.

I think when we ever get to rewrite rules, we can switch everything to use user_trailingslashit(), until then perhaps we can stick with trailingslashit().

[r-a-y]

In 11598:

Audit template link functions to use trailingslashit() where necessary.

Particularly, fixes issues on LightSpeed installs.

Props allianse, r-a-y.

Fixes #7448.