Access denied to Profile Fields admin screen - MS network activation

[estevao90]

After update BuddyPress to 2.8.0, can’t access the Profile Fields admin screen (User -> Profile Fields) to manage the custom fields, like delete and edit (mode edit_field and delete_field). When users access this screens, the message “Access Denied” is shown.

[hnla]

This appears to be a MS issue? reported on forums ticket as BP network activated issue.

Tested on fresh install of single site WP trunk & issue not seen.

Forum ticket:

​https://buddypress.org/support/topic/access-denied-to-profile-fields-admin-screen-in-bp-2-8-0/

[r-a-y]

In 11432:

XProfile Admin: Fix profile field edit and delete URLs for multisite.

See r11345 where this bug was introduced (#4646). admin_url() only
works for single-site installs, which broke compatibility with multisite.

This commit fixes this by using network_admin_url() instead of
admin_url(), which is both single-site and multisite-compatible.

Fixes #7445.

[r-a-y]

Thanks for reporting the bug, @estevao90.

This will be fixed for v2.8.1.

[r-a-y]

In 11433:

XProfile Admin: Fix profile field edit and delete URLs for multisite.

See r11345 where this bug was introduced (#4646). admin_url() only
works for single-site installs, which broke compatibility with multisite.

This commit fixes this by using network_admin_url() instead of
admin_url(), which is both single-site and multisite-compatible.

See #7445 (2.8-branch).

[johnjamesjacoby]

Should this use bp_get_admin_url() to help determine the dashboard for us? Or are those conditionals too specific?

[r-a-y]

Technically, no we do not have to use bp_get_admin_url() here since the "Users > Profile Fields" page is using the following to hook to the admin menu:

add_action( bp_core_admin_hook(), 'xprofile_add_admin_menu' );

bp_core_admin_hook() already does the network admin vs. single-site conditional logic to hook into the correct admin context, but it doesn't hurt to use bp_get_admin_url() if we wanted to.

[johnjamesjacoby]

That makes sense.

I'd like to revisit Profile admin area clean-up in BuddyPress 2.9, and reference this issue then (when that clean-up happens.)

[r-a-y]

In 11519:

XProfile Admin: Fix profile field edit and delete URLs for multisite installs where BuddyPress is not network-activated.

r11432 fixed the profile field edit and delete URLs for multisite installs
where BuddyPress is network-activated, but broke the URLs where
BuddyPress is not network-activated on a multisite install. See #7445,

This changeset rectifies the problem by using bp_get_admin_url() instead
of network_admin_url(). (JJJ is always right!)

Props johnjamesjacoby, NicolasKulka.

Anti-props r-a-y.

Fixes #7472 (trunk)

[r-a-y]

In 11520:

XProfile Admin: Fix profile field edit and delete URLs for multisite installs where BuddyPress is not network-activated.

r11432 fixed the profile field edit and delete URLs for multisite installs
where BuddyPress is network-activated, but broke the URLs where
BuddyPress is not network-activated on a multisite install. See #7445,

This changeset rectifies the problem by using bp_get_admin_url() instead
of network_admin_url(). (JJJ is always right!)

Props johnjamesjacoby, NicolasKulka.

Anti-props r-a-y.

Fixes #7472 (2.8-branch)