Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#7445 closed defect (bug) (fixed)

Access denied to Profile Fields admin screen - MS network activation

Reported by: estevao90 Owned by: r-a-y
Milestone: 2.8.1 Priority: normal
Severity: normal Version: 2.8.0
Component: Extended Profile Keywords:
Cc:

Description

After update BuddyPress to 2.8.0, can’t access the Profile Fields admin screen (User -> Profile Fields) to manage the custom fields, like delete and edit (mode edit_field and delete_field). When users access this screens, the message “Access Denied” is shown.

Change History (12)

#1 @hnla
2 years ago

  • Summary changed from Access denied to Profile Fields admin screen to Access denied to Profile Fields admin screen - MS network activation

#2 @hnla
2 years ago

This appears to be a MS issue? reported on forums ticket as BP network activated issue.

Tested on fresh install of single site WP trunk & issue not seen.

Forum ticket:

https://buddypress.org/support/topic/access-denied-to-profile-fields-admin-screen-in-bp-2-8-0/

#3 @r-a-y
2 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 11432:

XProfile Admin: Fix profile field edit and delete URLs for multisite.

See r11345 where this bug was introduced (#4646). admin_url() only
works for single-site installs, which broke compatibility with multisite.

This commit fixes this by using network_admin_url() instead of
admin_url(), which is both single-site and multisite-compatible.

Fixes #7445.

#4 @r-a-y
2 years ago

  • Component changed from Core to Extended Profile

Thanks for reporting the bug, @estevao90.

This will be fixed for v2.8.1.

#5 @r-a-y
2 years ago

  • Milestone changed from 2.8 to 2.8.1
  • Version set to 2.8.0

#6 @r-a-y
2 years ago

In 11433:

XProfile Admin: Fix profile field edit and delete URLs for multisite.

See r11345 where this bug was introduced (#4646). admin_url() only
works for single-site installs, which broke compatibility with multisite.

This commit fixes this by using network_admin_url() instead of
admin_url(), which is both single-site and multisite-compatible.

See #7445 (2.8-branch).

#7 @johnjamesjacoby
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Should this use bp_get_admin_url() to help determine the dashboard for us? Or are those conditionals too specific?

#8 @r-a-y
2 years ago

Technically, no we do not have to use bp_get_admin_url() here since the "Users > Profile Fields" page is using the following to hook to the admin menu:

add_action( bp_core_admin_hook(), 'xprofile_add_admin_menu' );

bp_core_admin_hook() already does the network admin vs. single-site conditional logic to hook into the correct admin context, but it doesn't hurt to use bp_get_admin_url() if we wanted to.

Last edited 2 years ago by r-a-y (previous) (diff)

#9 @johnjamesjacoby
2 years ago

That makes sense.

I'd like to revisit Profile admin area clean-up in BuddyPress 2.9, and reference this issue then (when that clean-up happens.)

#10 @johnjamesjacoby
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

#11 @r-a-y
2 years ago

In 11519:

XProfile Admin: Fix profile field edit and delete URLs for multisite installs where BuddyPress is not network-activated.

r11432 fixed the profile field edit and delete URLs for multisite installs
where BuddyPress is network-activated, but broke the URLs where
BuddyPress is not network-activated on a multisite install. See #7445,

This changeset rectifies the problem by using bp_get_admin_url() instead
of network_admin_url(). (JJJ is always right!)

Props johnjamesjacoby, NicolasKulka.

Anti-props r-a-y.

Fixes #7472 (trunk)

#12 @r-a-y
2 years ago

In 11520:

XProfile Admin: Fix profile field edit and delete URLs for multisite installs where BuddyPress is not network-activated.

r11432 fixed the profile field edit and delete URLs for multisite installs
where BuddyPress is network-activated, but broke the URLs where
BuddyPress is not network-activated on a multisite install. See #7445,

This changeset rectifies the problem by using bp_get_admin_url() instead
of network_admin_url(). (JJJ is always right!)

Props johnjamesjacoby, NicolasKulka.

Anti-props r-a-y.

Fixes #7472 (2.8-branch)

Note: See TracTickets for help on using tickets.