Skip to:
Content

BuddyPress.org

Changes between Version 1 and Version 2 of Ticket #7442, comment 11


Ignore:
Timestamp:
02/07/2018 11:37:22 AM (7 years ago)
Author:
DJPaul
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7442, comment 11

    v1 v2  
    33As far as the patch looks, we need to wrap the new query parts in `$wpdb->prepare()`, I think.
    44
    5 @boonebgorges Is the new query not being cached a blocker? If so, how long should it be cached for, and when should the cache be cleared? It seems to me at a glance that we'd have to clear said cache every time the users table is written to (which we can't do, when that table is running as a WP global table).
     5@boonebgorges Is the new query not being cached a blocker? If so, how long should it be cached for, and when should the cache be cleared? It seems to me at a glance that we'd have to clear said cache every time the users table is written to -- which we can't do, when that table is running as a WP global table. Which makes me question the benefit of caching it.